Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid 1 use of keyword hackery #1211

Merged
merged 1 commit into from Dec 2, 2020

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Nov 28, 2020

based on #1208
#1209 has some funky errors, but this change at least seems to work on old and new ruby alike

@olleolleolle
Copy link
Member

How I reviewed: I entered the Test tab of the ruby-head build target, then opened the tiny built-in search window, entered the word warning, and hit the arrow icon to navigate between the case-insensitive search hits. All of them were about other things.

This change works on latest Ruby.

Thanks, @grosser, for a meticulous fix!

@grosser
Copy link
Contributor Author

grosser commented Dec 2, 2020

rebased it for a clean merge

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olleolleolle olleolleolle merged commit e111db3 into lostisland:master Dec 2, 2020
@olleolleolle
Copy link
Member

@grosser Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants