Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native api fix rdebug recursion alt #1205

Merged
merged 5 commits into from Nov 13, 2020
Merged

Native api fix rdebug recursion alt #1205

merged 5 commits into from Nov 13, 2020

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Nov 12, 2020 •
edited

Description

Adds commit on top of #1204

Todos

List any remaining work that needs to be done, i.e:

  • Test with ruby-debug

native-api and others added 4 commits November 11, 2020 01:45
@native-api
Fix infinite recursion and NameError on load when running with -rdebug
7254560 
When running with `ruby -rdebug` with a breakpoint set, `self.to_str` (which is not defined) is called repeatedly during module load, including the time after the `class << self` block is loaded but before further blocks that add more bits to `self` are.
As such, the dynamic method resolution machinery has to not break in this partially initialized state.
@native-api
change style
6926078
@native-api
Alternative solution
340c0f4 
May break something due to submodules being loaded early
@iMacTia
Properly split Faraday constants in separate files
33f5bc5
This was referenced Nov 12, 2020
Closed
Closed
@native-api
Copy link

A way to test with -rdebug is:

$ bundle exec ruby -rdebug -e "require 'faraday'; puts Faraday::VERSION;" <<!
b foo:1
c
!

@native-api
Copy link

I confirm the PR to work:

bundle exec ruby -rdebug -e "require 'faraday'; puts Faraday::VERSION;" <<!
b foo:1
c
!
/home/vmuser/.rvm/rubies/ruby-2.5.8/lib/ruby/2.5.0/x86_64-linux/continuation.so: warning: callcc is obsolete; use Fiber instead
Debug.rb
Emacs support available.

/home/vmuser/.rvm/rubies/ruby-2.5.8/lib/ruby/site_ruby/2.5.0/rubygems/core_ext/kernel_require.rb:35:    RUBYGEMS_ACTIVATION_MONITOR.enter
(rdb:1) b foo:1
Set breakpoint 1 at foo:1
(rdb:1) c
1.1.0

@iMacTia iMacTia merged commit 1595e6f into master Nov 13, 2020
@iMacTia iMacTia deleted the native-api-fix_rdebug_recursion_alt branch November 13, 2020 09:00
@iMacTia iMacTia mentioned this pull request Nov 13, 2020
Closed
@bpo bpo mentioned this pull request Dec 31, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@native-api native-api native-api approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iMacTia @native-api