Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry_change_requests from documentation #1185

Merged
merged 1 commit into from Oct 6, 2020

Conversation

stim371
Copy link
Contributor

@stim371 stim371 commented Oct 1, 2020

Description

The net-http-persistent gem removed the #retry_change_requests adapter configuration with drbrain/net-http-persistent#100 in v4.0.0.

The net-http-persistent gem removed the #retry_change_requests adapter configuration with drbrain/net-http-persistent#100 in v4.0.0.
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to do.

If people are stuck on old versions, that could trip them up, but of course, the versioning of that gem is its issue, not ours.

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late to the party.
No objections from me, that was just an example anyway to show how to customise adapter-specific configs, so happy to remove it 👍

@iMacTia iMacTia merged commit 85b46be into lostisland:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants