Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces flat_encode option for multipart adapter. #1163

Merged
merged 1 commit into from Jul 9, 2020
Merged

Introduces flat_encode option for multipart adapter. #1163

merged 1 commit into from Jul 9, 2020

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jul 8, 2020

Description

Fixes #1157
In the end I opted for an option, as using the encoders would create further complications in case of custom encoders 馃槥

olleolleolle
olleolleolle approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this as an option!

馃憤 LGTM.

(I read the whitespace formatting changes, and found them to be formatting.)

@iMacTia iMacTia merged commit 5acab36 into master Jul 9, 2020
@iMacTia iMacTia deleted the fix/multipart-encoder branch July 9, 2020 09:43
@iMacTia iMacTia mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@technoweenie technoweenie Awaiting requested review from technoweenie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to upload multiple images as form-data with same key
2 participants
@iMacTia @olleolleolle