Update typhoeus to new stable version (1.4)
#1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, the build fails on RuboCop, do you think you can make it pass? |
I can, but I think it's not related to this PR, and I see you've already created #1160 |
|
Thanks, oh, right, I got some energy and got this (linting PR #1160) done at the end of my day. |
iMacTia
approved these changes
May 27, 2020
There was a problem hiding this comment.
Thanks @AlexWayfer!
I think we needed this due to a fix merged in master but not released yet. And then of course it went forgotten 😄.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the title. Released stable versions are better than git-versions.
Todos
List any remaining work that needs to be done, i.e: