Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return tests of Test adapter #1147

Merged
merged 1 commit into from Apr 20, 2020
Merged

Return tests of Test adapter #1147

merged 1 commit into from Apr 20, 2020

Conversation

AlexWayfer
Copy link
Contributor

Description

I want to improve Test adapter and I found out that tests for it was removed in #939

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

@AlexWayfer AlexWayfer mentioned this pull request Apr 17, 2020
Closed
@AlexWayfer
Copy link
Contributor Author

CI fails is not related to this PR.

@AlexWayfer
Copy link
Contributor Author

Rebased, CI is green. I need for this PR for #1146

olleolleolle
olleolleolle approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests back. LGTM!

@olleolleolle olleolleolle merged commit 87ecaf9 into lostisland:master Apr 20, 2020
@AlexWayfer AlexWayfer deleted the return_tests_of_test_adapter branch April 20, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexWayfer @olleolleolle