Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #1087

Merged
merged 16 commits into from
Dec 27, 2019
Merged

Update ci.yml #1087

merged 16 commits into from
Dec 27, 2019

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Dec 10, 2019

Description

Uses RVM to test 0.1x branch against correct ruby versions.

Verified

This commit was signed with the committer’s verified signature.
antfu Anthony Fu

Verified

This commit was signed with the committer’s verified signature.
antfu Anthony Fu

Verified

This commit was signed with the committer’s verified signature.
antfu Anthony Fu

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this change makes it work: refer to RVM source builds.

Then, the next change was: refer to 2.0.0 instead of 2.0 (which was interpreted as 2 in the resulting CLI command).

What didn't work after that was: using RubyGems 3.0.6 on Ruby 1.9. RubyGems 3.0.0 dropped that support.

Error running 'env GEM_HOME=/home/runner/.rvm/gems/ruby-1.9.3-p551@global GEM_PATH= /home/runner/.rvm/rubies/ruby-1.9.3-p551/bin/ruby -d /home/runner/.rvm/src/rubygems-3.0.6/setup.rb --no-document',

rvm seems to have some support for installing another than the regular version of RubyGems, but it looks like only after a Ruby version has been fully installed (incl. the above-mentioned rubygems-3.0.6).

https://rvm.io/rubies/rubygems

@iMacTia
Copy link
Member Author

iMacTia commented Dec 27, 2019

Couldn't manage to make it work with 1.9, but I really run out of time so this will do for now 😅
Added back CI support for 2.0+ 🎉

@iMacTia iMacTia merged commit 9b1fd02 into 0.1x Dec 27, 2019
@iMacTia iMacTia deleted the 0.1x-CI-fix branch December 27, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants