Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1x spec #1058

Merged
merged 4 commits into from Oct 17, 2019
Merged

0.1x spec #1058

merged 4 commits into from Oct 17, 2019

Conversation

technoweenie
Copy link
Member

Runs rspec on 0.1x, to ensure the error_spec.rb file introduced in #1054 is actually run.

Also gitignores the ./docs dir. It contains the github pages files, which didn't exist back then.

@technoweenie technoweenie changed the base branch from master to 0.1x October 17, 2019 20:11
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some happy comments.

Thanks for taking this on!

Gemfile Show resolved Hide resolved
# - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
# - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
# - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
config.disable_monkey_patching!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable this one, it's good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but it's not enabled on master right now :)

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking clear and shiny! LGTM!

@technoweenie technoweenie merged commit 09b4ec7 into 0.1x Oct 17, 2019
@iMacTia iMacTia deleted the 0.1x-spec branch October 18, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants