feat: Adding support for streamed responses #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: #5 This adds support for a streamed response and is based on the implementation I saw https://github.com/lostisland/faraday-net_http/blob/9534fd19bd4898f28361ea60dbc3867edadc15ad/lib/faraday/adapter/net_http.rb#L106-L120
MikeRogers0
commented
Jul 11, 2021
| http_response | ||
| else | ||
| http.request(env[:url], create_request(env)) | ||
| end |
There was a problem hiding this comment.
This approach is based on https://github.com/lostisland/faraday-net_http/blob/9534fd19bd4898f28361ea60dbc3867edadc15ad/lib/faraday/adapter/net_http.rb#L106-L120
Though I'm happy to hear if you think there is a better way :)
|
My manual tests look good. I tested this feature against a get of a largish (12 MB) file. The size and md5sum were the same for all of these tests run against this feature branch:
|
iMacTia
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Thank you so much @MikeRogers0 for porting this feature from the net_http adapter and @wconrad for testing with large files as well 🙌
LGTM 🎉 !
|
You guys are truly awesome. Thanks @iMacTia and @MikeRogers0 ! |
tisba
added a commit
to tisba/awesome-faraday
that referenced
this pull request
Sep 15, 2023
lostisland/faraday-net_http_persistent#6 implemented streaming response support and it was release in 1.2.0 (see https://github.com/lostisland/faraday-net_http_persistent/releases/tag/v1.2.0)
olleolleolle
pushed a commit
to lostisland/awesome-faraday
that referenced
this pull request
Sep 15, 2023
lostisland/faraday-net_http_persistent#6 implemented streaming response support and it was release in 1.2.0 (see https://github.com/lostisland/faraday-net_http_persistent/releases/tag/v1.2.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5
This adds support for a streamed response and is based on the
implementation I saw https://github.com/lostisland/faraday-net_http/blob/9534fd19bd4898f28361ea60dbc3867edadc15ad/lib/faraday/adapter/net_http.rb#L106-L120
The tests are all passing (Yay), I also ran the steps to reproduce provided by @wconrad (Thank you so much, this helped a bunch) locally & had the result (I also tried a few other links, though I didn't check any massive files):
