New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict mode warning still refers to NODE_ENV variable even if overriding with NODE_CONFIG_ENV is used #460
Comments
And what is the |
@markstos, Right I'm using latest version - 1.28.0 (which was actually upgraded namely for this new feature). But the problem is that current warning message may confuse user, since in situation when environment is defined via NODE_CONFIG_ENV, warning message still mentions NODE_ENV. |
PR welcome. |
@markstos @fedulovivan - PR added 🙂 |
Published @3.2.3 - thanks! |
FIX #460 - Strict mode warning refer to appropriate env variable
When environment is overwritten via NODE_CONFIG_ENV, warning message should also consider this.
Given:
app is launched as
NODE_CONFIG_ENV=ut NODE_ENV=production node index.js
no configuration file at path config/ut.json
Actual message in console:
WARNING: NODE_ENV value of 'ut' did not match any deployment config file names.
Expected message:
WARNING: NODE_CONFIG_ENV value of 'ut' did not match any deployment config file names.
The text was updated successfully, but these errors were encountered: