Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector.prototype.isRelational returns a function #220

Open
achrinza opened this issue May 10, 2022 · 0 comments
Open

Connector.prototype.isRelational returns a function #220

achrinza opened this issue May 10, 2022 · 0 comments
Labels

Comments

@achrinza
Copy link
Member

Steps to reproduce

Call new Connector(/*...*/).isRelational()

Offending line:

return this.isRelational ||
(this.getTypes().indexOf('rdbms') !== -1);

Current Behavior

It returns itself (a function), which then requires a 2nd call to get the expected boolean value.

Expected Behavior

Connector.prototype.isRelational should strictly return a boolean.

Link to reproduction sandbox

N/A

Additional information

Related Issues

See Reporting Issues for more tips on writing good issues

@achrinza achrinza added the bug label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Icebox
Development

No branches or pull requests

1 participant