Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty body on update generates an MySQL error #478

Open
A-Corregidor opened this issue Jan 4, 2023 · 2 comments
Open

Empty body on update generates an MySQL error #478

A-Corregidor opened this issue Jan 4, 2023 · 2 comments
Labels

Comments

@A-Corregidor
Copy link

Steps to reproduce

Generate a new project (ex: loopback example todo-list), change DB from memory objecto to MySQL, create MySQL database and config connector. Seed database with some data.

Make a PATCH request that uses updateById repository's method, with an empty body (ex: updatebyId(existingId, {}).

Current Behavior

Query fails with an SQL syntax error: "Error: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE id='3db97b64-a616-11ec-8940-0db8a28d8117'".

This error does not occur when using a memory database.

Query sent to DB (without params) is: "UPDATE ModelA SET WHERE id=?"

Expected Behavior

A - No query should be sent to DB
B - Send correct (but useless) query to DB

@A-Corregidor
Copy link
Author

Up!

1 similar comment
@Habbiton
Copy link

Habbiton commented Oct 6, 2023

Up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants