From 075f913f6a925e14490dd97af9c11c6a1bc0c5af Mon Sep 17 00:00:00 2001 From: Daniel Marcotte Date: Thu, 23 Apr 2020 07:07:12 -0700 Subject: [PATCH] Add rationale for commenting out `s.extensions` Just a quick note for future us on _why_ this is commented out. --- puma.gemspec | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/puma.gemspec b/puma.gemspec index 6de11e18ce..2036aa5e2a 100644 --- a/puma.gemspec +++ b/puma.gemspec @@ -10,7 +10,11 @@ Gem::Specification.new do |s| s.summary = "Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server for Ruby/Rack applications" s.email = ["evan@phx.io"] s.executables = ["puma", "pumactl"] - #s.extensions = ["ext/puma_http11/extconf.rb"] + + ## + # disable the C native extension part of this Gem---we want JRuby to be the default + # so we get that version when using a :git Gemfile dependency + # s.extensions = ["ext/puma_http11/extconf.rb"] s.add_runtime_dependency "nio4r", "~> 2.0" s.metadata["msys2_mingw_dependencies"] = "openssl" s.files = `git ls-files -- bin docs ext lib tools`.split("\n") +