Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension fails to load on new mac m1 chips #460

Closed
mfcoxo opened this issue Jan 11, 2021 · 2 comments
Closed

Extension fails to load on new mac m1 chips #460

mfcoxo opened this issue Jan 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mfcoxo
Copy link

mfcoxo commented Jan 11, 2021

Describe the bug
Due to an issue in fast-glob (mrmlnc/fast-glob#296) the extension will fail to run on the new m1 chips.
Tested editing the code in i18n-ally extension folder (extension.js) to add the new Math.max and it works.
Once there is a new version of fast-glob would be great to update the dependency.

Extension Version
2.4.17

To Reproduce
Steps to reproduce the behavior:

  1. Install vscode insiders
  2. Install i18n-ally
  3. Won't run

Device Infomation

  • OS: macOS Big Sur
  • Version: 11.1
  • VS Code Version: 1.53.0-insider

Extension Log

fastqueue concurrency must be greater than 1
@mfcoxo mfcoxo added the bug Something isn't working label Jan 11, 2021
@antfu antfu closed this as completed in 5a7253c Jan 12, 2021
@antfu
Copy link
Contributor

antfu commented Jan 12, 2021

Updated in v2.4.18. @mfcoxo can you help to check if the new version works on M1? Thanks.

@mfcoxo
Copy link
Author

mfcoxo commented Jan 12, 2021

Yup. Works fine.
My cmd click on the translation key seems to have stopped working. Might be because vscode insiders released a new update.
If I hover the translation and press the arrow it will go to the translation correctly.

Thank you for the quick update.

Edit: Indeed my cmd click has returned. Don't think it has any connection with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants