Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App goes all white. JavaScript error when attempting to close it. #3344

Closed
chadkennedyonline opened this issue Dec 3, 2021 · 3 comments
Closed
Labels
awaiting-response Issue will be closed if a reply is not received os:windows

Comments

@chadkennedyonline
Copy link

Describe the bug
JavaScript error when attempting to close the app, requiring kill via Task Manager.

To Reproduce
Steps to reproduce the behavior:

  1. Get app into a state such that it just displays an entirely white screen. See additional context section below.
  2. Click on the 'X' in the upper right to close the window.
  3. Error dialog pops up with title "A JavaScript error occurred in the main process" and content:
Uncaught Exception:
Error: Render frame was disposed before WebFrameMain could be accessed
   at Object.n.send (node:electron/js2c/browser_init:169:413)
   at Object.b.send (node:electron/js2c/browser_init:165:2492)
   at BrowserWindow.<anonymous>
(C:\Users\chad\AppData\Local\Logseq\app-0.5.1\resources\app\electron.js:13688:38)
   at BrowserWindow.emit (node:events:406:35)

Closing this error just takes me back to LogSeq with the white screen.

Expected behavior
Normal "Application is not responding" dialog from Windows, with buttons to "Close the program" or "Wait for the program to respond" upon clicking the 'X' when in this state. Or, even better, a LogSeq-generated prompt to restart, similar to what Slack does.

Screenshots

LogSeq with white screen
image

Error that pops up when closing
image

Example of desired, normal "Application is not responding" dialog from Windows
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Desktop App
  • Version 0.5.1

Additional context
Issue #3054 sees a similar dialog pop up.

I believe this may be fixable by just updating electron to 15.2.0. See in the release notes the first fix listed.

Regarding step 1: The browser backend occasionally gets hung up on my machine. This manifests as both my browser windows and all Electron apps getting hung up. Once in this state, when I click the "X" to close browser windows, I get the normal "Application is not responding" dialog from Windows. For Slack, when I click the "X" to close it, the app itself actually prompts me to reload via an internally generated dialog. But for LogSeq I get the behavior described above, and the only resolution is to use the Task Manager to kill it. I'm sorry I don't have better repro steps for step 1 above. I believe the root of the issue is my use of the Distill browser extension to poll web pages throughout the night.

After killing LogSeq with the Task Manager and restarting it, everything seems fine, with no ill effects.

@andelf
Copy link
Collaborator

andelf commented Dec 10, 2021

v0.5.2 has upgraded electron to 16.0.4.
Is this still appear?

@andelf andelf added awaiting-response Issue will be closed if a reply is not received os:windows labels Dec 10, 2021
@chadkennedyonline
Copy link
Author

Not yet, but the condition that causes it hasn't happened yet. Will update here as soon as it does.

@chadkennedyonline
Copy link
Author

chadkennedyonline commented Dec 29, 2021

Confirmed today this is still an issue, using 0.5.5.

image

@Bad3r Bad3r closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Issue will be closed if a reply is not received os:windows
Projects
None yet
Development

No branches or pull requests

3 participants