Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that building arrays does not happen to objects with leng… #2399

Merged
merged 1 commit into from Oct 5, 2019

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Oct 5, 2019

🔎 Overview

As reported in #2398, rules with length param will get treated as arrays by mistake. This PR adds an additional check to prevent trying to call map.

Issues affected

closes #2398

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #2399 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2399   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          44       44           
  Lines        1058     1058           
  Branches      159      159           
=======================================
  Hits         1008     1008           
  Misses         50       50
Impacted Files Coverage Δ
src/validate.ts 96.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d9a51...cd9a20f. Read the comment docs.

@logaretm logaretm merged commit f8d4e42 into master Oct 5, 2019
@logaretm logaretm deleted the fix/2398 branch October 5, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with object format rules contained in object
1 participant