Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove uneeded check when provider re-renders closes #2388 #2397

Merged
merged 1 commit into from Oct 5, 2019

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Oct 5, 2019

🔎 Overview

Fixes a bug introduced by #2355 where a value of undefined would be skipped.

Issues affected

closes #2388

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #2397 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
+ Coverage   95.18%   95.27%   +0.08%     
==========================================
  Files          44       44              
  Lines        1059     1058       -1     
  Branches      159      159              
==========================================
  Hits         1008     1008              
+ Misses         51       50       -1
Impacted Files Coverage Δ
src/components/common.ts 98.38% <ø> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16f329...6c1f3f3. Read the comment docs.

@logaretm logaretm merged commit 41d2f58 into master Oct 5, 2019
@logaretm logaretm deleted the fix/2388 branch October 5, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object Validation
1 participant