Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty rules expressions #2389

Merged
merged 1 commit into from Sep 29, 2019
Merged

fix: allow empty rules expressions #2389

merged 1 commit into from Sep 29, 2019

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Sep 29, 2019

πŸ”Ž Overview

This PR allows having empty pipes in string rules and aims to close #2386

||||required

βœ” Issues affected

closes #2386

@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

Merging #2389 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2389      +/-   ##
==========================================
+ Coverage   95.17%   95.18%   +<.01%     
==========================================
  Files          44       44              
  Lines        1058     1059       +1     
  Branches      159      159              
==========================================
+ Hits         1007     1008       +1     
  Misses         51       51
Impacted Files Coverage Ξ”
src/utils/index.ts 95% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 66bf95c...47b95a5. Read the comment docs.

@logaretm logaretm merged commit 94d09d6 into master Sep 29, 2019
@logaretm logaretm deleted the fix/allow-empty-rules branch November 14, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String validation with empty rule ('||') causes an error
1 participant