Propagate ValidationObserver's errors added via setErrors #2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables error propagation, so calling setErrors on parent (form-level) observer will be enough and errors will be rendered even on providers which are children of nested observers.
Example of issue here: https://codesandbox.io/s/veevalidate-30-manually-setting-errors-iknf0
This will be quite useful for those who have such structure:
Current implementation requires you not only to call setErrors on parent observer, but also on each nested ValidationObserver, so snippet like this has to be added every time:
Note that this snippet is for one-level nesting. I'm not sure if anyone would need to have ValidationObserver > ValidationObserver > ValidationObserver, but then the code will be even more complicated.
If you think that it's better to keep setErrors simple, maybe another method should be added for this feature, I can make another PR.