Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In setInteractionMode function, implementation parameter should be optional parameter #2352

Merged

Conversation

WarisR
Copy link
Contributor

@WarisR WarisR commented Sep 20, 2019

πŸ”Ž Overview

(SetInteractiveMode)
This PR fixes the bug by adds ? to make implementation parameter of setInteractiveMode to be optional parameter

πŸ€“ Code snippets/examples (if applicable)

export const setInteractionMode = (mode: string, implementation?: InteractionModeFactory) => {

βœ” Issues affected

list of issues formatted like this:

closes #2351

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #2352 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2352   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          44       44           
  Lines        1029     1029           
  Branches      152      152           
=======================================
  Hits          979      979           
  Misses         50       50
Impacted Files Coverage Ξ”
src/modes.ts 100% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update db98d68...8d24460. Read the comment docs.

@logaretm logaretm merged commit 576951d into logaretm:master Sep 20, 2019
@logaretm
Copy link
Owner

Good catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In setInteractionMode function, implementation parameter should be optional parameter
2 participants