Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding function(req, res) support to connectLogger options->nol… #1279

Merged
merged 2 commits into from Jul 4, 2022
Merged

feat: adding function(req, res) support to connectLogger options->nol… #1279

merged 2 commits into from Jul 4, 2022

Conversation

eyoboue
Copy link
Contributor

@eyoboue eyoboue commented Jul 3, 2022

#1278 Adding connectLogger options.nolog -> (req, res).
Example:

const connectLogger = log4js.connectLogger(logger, { nolog: (req, res) => res.statusCode < 400 });

@lamweili lamweili added the enhancement New feature or request label Jul 3, 2022
@lamweili lamweili linked an issue Jul 3, 2022 that may be closed by this pull request
Feature: function (req, res) as nolog option #1278
Closed
@lamweili lamweili added this to the 6.5.3 milestone Jul 3, 2022
@lamweili
Copy link
Contributor

lamweili commented Jul 3, 2022

@eyoboue, thanks!
Can you also update the docs/connect-logger.md for https://log4js-node.github.io/log4js-node/connect-logger.html?

@eyoboue eyoboue mentioned this pull request Jul 3, 2022
Closed
@lamweili lamweili merged commit 6acc345 into log4js-node:master Jul 4, 2022
lamweili
lamweili approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyoboue Thanks for the PR, LGTM!

@lamweili lamweili mentioned this pull request Jul 6, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 7, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamweili lamweili lamweili approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

Feature: function (req, res) as nolog option
2 participants
@eyoboue @lamweili