New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run prettier and require it #1271
Conversation
Hmm, it broke the Windows tests? The created test files should have been deleted on test teardown I believe. |
That one particular test file has been appearing on my computer every time I ran the test. Even on the previous branch I used. I never opened the configuration-validation-test, but it started appearing one day, and then it always appeared after every time I ran the test afterwards. |
It looks like the windows node 16 test should work faster after we run an |
@peteriman, windows tests went through this time, there were a couple files missing on the .gitattributes that caused them to download with crlf line endings instead of lf like the editorconfig/prettier wants. |
64bad65
to
68fcec4
Compare
I made some changes to the commits:
|
@peteriman, I ran prettier accross the entire project, and like the logfaces-http, it now is part of the pretest config.