Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier and require it #1271

Merged
merged 4 commits into from Jun 22, 2022
Merged

Run prettier and require it #1271

merged 4 commits into from Jun 22, 2022

Conversation

ZachHaber
Copy link
Contributor

@peteriman, I ran prettier accross the entire project, and like the logfaces-http, it now is part of the pretest config.

@lamweili
Copy link
Contributor

lamweili commented Jun 20, 2022

Hmm, it broke the Windows tests?

The created test files should have been deleted on test teardown I believe.

@ZachHaber
Copy link
Contributor Author

Hmm, it broke the Windows tests?

The created test files should have been deleted on test teardown I believe.

That one particular test file has been appearing on my computer every time I ran the test. Even on the previous branch I used. I never opened the configuration-validation-test, but it started appearing one day, and then it always appeared after every time I ran the test afterwards.

@ZachHaber
Copy link
Contributor Author

It looks like the windows node 16 test should work faster after we run an npm install or update locally to let the package-lock.json file update to version 2.

@ZachHaber
Copy link
Contributor Author

@peteriman, windows tests went through this time, there were a couple files missing on the .gitattributes that caused them to download with crlf line endings instead of lf like the editorconfig/prettier wants.

@lamweili lamweili force-pushed the prettier branch 2 times, most recently from 64bad65 to 68fcec4 Compare June 22, 2022 16:56
@lamweili
Copy link
Contributor

lamweili commented Jun 22, 2022

I made some changes to the commits:

  • merged the two commits for .gitattributes together
  • added a commit (e378b59) to refactor eslint comments so prettier can fix properly
  • removed the commit that added test/tap/freeze-date-file-test to .gitignore as it is not part of prettier fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants