Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Appender Type extensible from other modules and the user #1267

Merged
merged 3 commits into from Jun 9, 2022

Conversation

ZachHaber
Copy link
Contributor

Appender was a discriminated type union, which unfortunately made it so that it wasn't able to be modified. Now you can update the Appenders interface with new values to enable modification.

declare module './log4js' {
  interface Appenders {
    StorageTestAppender: {
      type: 'storageTest';
      storageMedium: 'dvd' | 'usb' | 'hdd';
    };
  }
}

Most of the changes in this PR are prettier being run, as I also set up the editorconfig to apply properly to typescript files as well.

The gitattributes was also missing typescript files.

@lamweili lamweili added this to the 6.5.3 milestone Jun 9, 2022
@lamweili lamweili added the enhancement New feature or request label Jun 9, 2022
Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZachHaber Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants