Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add level parameter declaration to Logger.log function #1115

Merged
merged 2 commits into from Jan 11, 2022

Conversation

ZLundqvist
Copy link
Contributor

Minor typedef improvement that better reflects the implementation, and also helps guide TypeScript developers using Logger.log.

@lamweili lamweili linked an issue Jan 9, 2022 that may be closed by this pull request
@lamweili lamweili added this to the 6.4.0 milestone Jan 9, 2022
Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to remove the extra spacing between string and ,

@lamweili lamweili assigned lamweili and unassigned lamweili Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function log's parameter is wrong in .d.ts
2 participants