Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.EOL should be tested before being returned. #1404

Open
robertlight opened this issue Nov 15, 2023 · 0 comments
Open

os.EOL should be tested before being returned. #1404

robertlight opened this issue Nov 15, 2023 · 0 comments

Comments

@robertlight
Copy link

If we are using log4js inside a browser, os.EOL is undefined.

therefore, I would recommend the following line:

log4js-node/lib/layouts.js

Line 225 in bd45788

return os.EOL;

should be:
return os.EOL?os.EOL:'\n';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertlight