Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Able to intercept logger #1387

Open
loynoir opened this issue May 20, 2023 · 3 comments
Open

[feat] Able to intercept logger #1387

loynoir opened this issue May 20, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@loynoir
Copy link

loynoir commented May 20, 2023

Scenario

const logger = log4js.getLogger("foo");

function bar1(_n: number) {
  logger.error(new Error("bar"));
}

function bar2(_n: number) {
  logger.error(new Error("bar"));
}

function bar3(_n: number) {
  logger.error(new Error("bar"));
}

bar1(42);
bar2(42);
bar3(42);

Usage

log4js.intercept(
  // logger category matcher
  "foo",
  // logger method matcher
  "error",
  async (originalFn, originalParam) => {
    if (originalParam[0] instanceof Error) {
      await originalFn(sourcemap.getNearSourceCodeFromErrorStack(originalParam[0]));
    }

    await originalFn(...originalParam);
  }
);

Workaround

const log4jsPatch = {
  getLogger(category: string) {
    const originalLogger = log4js.getLogger(category);

    const $trace = originalLogger.trace.bind(originalLogger);
    const $debug = originalLogger.debug.bind(originalLogger);
    const $info = originalLogger.info.bind(originalLogger);
    const $warn = originalLogger.warn.bind(originalLogger);
    const $error = originalLogger.error.bind(originalLogger);
    const $fatal = originalLogger.fatal.bind(originalLogger);

    return {
      trace: $trace,
      debug: $debug,
      info: $info,
      warn: $warn,
      error(...originalParams: any[]) {
        if (originalParams[0] instanceof Error) {
          $error(sourcemap.getNearSourceCodeFromErrorStack(originalParams[0]))
        }

        $error(...originalParams)
      },
      fatal: $fatal,
    };
  },
};

const logger = log4jsPatch.getLogger("foo");

function bar1(_n: number) {
  logger.error(new Error("bar"));
}

function bar2(_n: number) {
  logger.error(new Error("bar"));
}

function bar3(_n: number) {
  logger.error(new Error("bar"));
}

bar1(42);
bar2(42);
bar3(42);
@lamweili
Copy link
Contributor

lamweili commented May 20, 2023

Hi, mind explaining a bit more?
I'm not sure what is the wrapper() is doing in your workaround or what are you trying to achieve.

@lamweili lamweili added the enhancement New feature or request label May 20, 2023
@lamweili lamweili added this to the 6.9.2 milestone May 20, 2023
@loynoir
Copy link
Author

loynoir commented May 20, 2023

@lamweili

Comment updated.

wrapper() print the nearby source code which cause this error.

@lamweili
Copy link
Contributor

lamweili commented May 20, 2023

I see. You can create a PR for it! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants