Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform lazy parsing of the call stack information #1343

Open
Mumeii opened this issue Nov 11, 2022 · 0 comments
Open

Perform lazy parsing of the call stack information #1343

Mumeii opened this issue Nov 11, 2022 · 0 comments

Comments

@Mumeii
Copy link
Contributor

Mumeii commented Nov 11, 2022

Hi

I've noticed that there is a enableCallStack option in the category configuration part.

Although it's nice to be able to enable / disable such a feature, I think that it should only concerne the recording of the Error object, not its processing

The processing of those Error object should only be performed lazily, because you can't tell ahead of time if those call stack informations will really be used ...

It all depends on :

  • the way the patterns of PatternLayout are configured
  • the way the user code play with the logEvents log4js give access to

Because of the previous point, it's hard if not impossible for log4js code to guess it while processing the configuration.

So the best solution should be to use a lazy computation technic I guess ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant