New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency regarding configure signature of AppenderModule with typescript #1292
Comments
Thanks, I have corrected the typings in PR #1304. On initialisation, the log4js-node/lib/appenders/index.js Lines 117 to 122 in 0c37f40
But it is up to individual appenders whether to use and take in the parameters.
log4js-node/lib/appenders/file.js Line 135 in 0c37f40
|
@lamweili thanks!! |
@ofekisr Pull requests are always welcomed! |
There is some inconsistency between the documentation and typescript types
regarding the configure signature of AppenderModule and there is no findAppender declaration in log4js.d.ts
What do you think?
please review the three states below:
from: appenders Advanced configuration doc - configure defined with four arguments
from: writing appenders doc - configure defined with only two arguments
from: https://github.com/log4js-node/log4js-node/blob/master/types/log4js.d.ts - configure defined without findAppender
there is no declaration of findAppender - I can't defined my own Appender as middleware Appender - I can't reach the next appenders
The text was updated successfully, but these errors were encountered: