This repository has been archived by the owner on Mar 29, 2024. It is now read-only.
use i64 for lease ttl and LeaseId type for ttl request #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbirtles
force-pushed
the
lease_ttl
branch
from
34e38b9
to
4aa1c72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TTL was being cast to u64, but it really should be an i64. When the lease is expired the ttl on a
LeaseTimeToLiveRequestis returned as-1for example.Also changed the
LeaseTimeToLiveRequestto use theLeaseIdtype instead of u64.