warn that it's emulating php-on-linux #424
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to issue locutusjs#395
kvz
approved these changes
Oct 2, 2020
|
This has been released under locutus@2.0.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #395
Description
the escape rules for windows is quite different, and PHP checks what OS it's compiled for and change the escapeshellarg() behaviour accordingly, but our escapeshellarg function does not check anything, it just always assumes it's running on
WindowsLinux.we should at the very least warn about it
(also i see 2 bugs in the function, but that's unrelated and should go in different PR's)