Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response times get graphed as zero before first request is made #1852

Closed
obradovichv opened this issue Aug 17, 2021 · 0 comments
Closed

Response times get graphed as zero before first request is made #1852

obradovichv opened this issue Aug 17, 2021 · 0 comments

Comments

@obradovichv
Copy link
Contributor

I'd like to not have a line for response times at all until requests have actually been reported (the first part of the line in this screen shot)

image

Originally posted by @cyberw in #1851 (comment)
@obradovichv obradovichv mentioned this issue Aug 17, 2021
Merged
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 17, 2021
@obradovichv
fix(charts): prevent displaying stats before requests are made
df8bd25 
Stat history would be charted by the client as a stream of consciousness
from the runners until they are stopped.
The client will no longer show unquantified stats (represented by the
number of requests).

Issue: locustio#1852
@obradovichv obradovichv mentioned this issue Aug 17, 2021
Merged
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 17, 2021
@obradovichv
test(stats): verify incorrect current response time percentile result
aab870c 
test case test_get_current_response_time_percentile_outside_cache_window
verifies incorrect behaviour returning None instead of 0 when time is outside
window of cached times.

Issue: locustio#1852
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 17, 2021
@obradovichv
fix(stats): return 0 when current response time not in percentile window
2424737 
Issue: locustio#1852
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 18, 2021
@obradovichv
fix(stats): avoid passing stats history before requests have been made
d8c9019 
Issue: locustio#1852
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 18, 2021
@obradovichv
feat(charts): add a marker line between test runs on the client
3efefdf 
Creates dummy placeholders in the stats history to space between the marker
and the line data.

Issue: locustio#1852
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 18, 2021
@obradovichv
fix(stats): return None when current response time not in percentile …
9137f57 
…window

This prevents the data from being displayed on the UI chart during the
response time calculation's indeterminate state.

Issue: locustio#1852
obradovichv added a commit to obradovichv/locust that referenced this issue Aug 19, 2021
@obradovichv
feat(charts): mark test runs with leading line markers
3b11573 
Mark start of first run on the chart once we start the second run.
Hook stop/start markers of test runs into update loop of stats.

Issue: locustio#1852
@cyberw cyberw closed this as completed Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyberw @obradovichv