Add goup handling in JSON transformations.

[marmarosi]

Resolves #49. Usage:

const res = targetOfjs(js, {includeGroups: true})
const res = sourceOfjs(js, {includeGroups: true})

[adrai]

Can you include a test?

[adrai]

Do you also want to support groups in the createxliff functions? If so, should we skip the includeGroups option completely and respect groups always (as soon as the object property is an object and not a string?)
What do you think?

[marmarosi]

It seems feasible. I give it a try...

[adrai]

Can you write the tests like the existing ones?

[marmarosi]

1. sourceOfjs & targetOfjs:
   options { includeGroups: true } removed
   handle nested groups as well
   handle group notes

2, js2xliff & js2xliff12:
handle groups and nested groups
handle group notes

3. Bugfix: js2xliff & js2xliff12 convert multiple notes correctly
   instead of <note>note1,note2</note>
   now <note>note1</note><note>note2</note>

I cannot run browserify and mocha tests on Windows, therefore created some functional test in test/mj/*.

[marmarosi]

I get the following errors:

$ ./node_modules/.bin/browserify --standalone xliff cjs/index.js -o xliff.js

D:\Development\logikum\xliff\cjs\index.js:1
import xliff2js from './xliff2js.js';
^
ParseError: 'import' and 'export' may appear only with 'sourceType: module'

$ ./node_modules/.bin/mocha test -R spec

D:\Development\logikum\xliff\cjs\index.js:1
import xliff2js from './xliff2js.js';
^^^^^^

SyntaxError: Cannot use import statement outside a module

[adrai]

Tests should run also on windows... what's the problem?

[adrai]

Which node version are you using?

[marmarosi]

node.js v16.3

[marmarosi]

I have found this idea: https://stackoverflow.com/questions/40029113/syntaxerror-import-and-export-may-appear-only-with-sourcetype-module-g, but do not know how to apply.

[adrai]

Ok, it should work on windows now: https://github.com/locize/xliff/runs/4684040716?check_suite_focus=true
Can you update your branch?

[marmarosi]

I check it...

[marmarosi]

Funny... I see your changes on Github, but git does not fetch anything.

[adrai]

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[adrai]

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Are you able to sync your fork?

[marmarosi]

Still cannot run tests. I did successfully:
git fetch upstream
git checkout master
git merge upstream/master
...and I get the same errors. Even when I change to include-groups branch.

[adrai]

From what I see published here (https://github.com/marmarosi/xliff/tree/include-groups), I can't see any updates?

And based on the Github Windows tests, it works successfully: https://github.com/locize/xliff/runs/4684040716?check_suite_focus=true

[adrai]

If you prefer, you can delete everything and create a new PR...

[marmarosi]

Adding ,/node_modules/.bin to PATH resolved my babel problem. However, some tests now fails, I suppose as a result of my amendments. I need to review them...

[marmarosi]

I think the PR is error free now.

[adrai]

thank you for your contribution
released with v6.0.0