Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Subscription #38

Open
lmittmann opened this issue Jan 27, 2023 · 4 comments
Open

Support Subscription #38

lmittmann opened this issue Jan 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@lmittmann
Copy link
Owner

No description provided.

@kamikazechaser
Copy link

If I may ask, is this feature meant to be a new websocket implementation or a wrapper over the existing ethclient?

@lmittmann
Copy link
Owner Author

The idea is to use the existing go-ethereum/rpc implementation. The challenge is to be able to do the subscription in a batch call, so the w3.Client API does not need to be extended. This would require changes to go-ethereum/rpc though.

@lmittmann lmittmann added the enhancement New feature or request label Mar 10, 2023
@lmittmann lmittmann mentioned this issue Jul 23, 2023
Closed
@rtunazzz
Copy link
Contributor

This would be nice!

I'd also like to suggest support for both WSS & HTTP implementations (i.e. using eth_subscribe where possible & replace with polling for RPCs that do not support that method). This would be identical with how ethers-js handles this.

@lmittmann
Copy link
Owner Author

Unfortunately I don't see a feasible path to creating a subscription within a batch request using go-ethereum/rpc. Idea's are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmittmann @kamikazechaser @rtunazzz