Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qs.stringify Uncaught RangeError: Cyclic object value #403

Closed
Ockejanssen opened this issue Mar 23, 2021 · 7 comments · Fixed by #426
Closed

qs.stringify Uncaught RangeError: Cyclic object value #403

Ockejanssen opened this issue Mar 23, 2021 · 7 comments · Fixed by #426

Comments

@Ockejanssen
Copy link

var qs = require('qs');
var a = ['a'];
qs.stringify({x:a,y:a});

-> Uncaught RangeError: Cyclic object value

@ljharb
Copy link
Owner

ljharb commented Mar 23, 2021

This should be fixed in v6.10.1 (see #402). Can you confirm which version of qs you're using?

@Ockejanssen
Copy link
Author

I tested this one with "version": "6.10.1"

@ljharb
Copy link
Owner

ljharb commented Mar 24, 2021

Thanks, I can reproduce this.

@pober
Copy link

pober commented Apr 13, 2021

Any updates on this?
This affects latest version if superagent module.

@ljharb
Copy link
Owner

ljharb commented Apr 13, 2021

No, I haven't come up with a fix yet. A PR in the meantime would be welcome.

@irhamputra
Copy link

Hi @ljharb, i try with umd file with qs@6.10.1, sometimes the bug is still there sometimes not 😕 should i use different version?

@ljharb
Copy link
Owner

ljharb commented Nov 10, 2021

@irhamputra i mean, it's 2021, nobody should be using UMDs for anything - but certainly if the UMD version is different than the real one, that's a bug somewhere.

ljharb added a commit to liaokunhua/qs that referenced this issue Dec 6, 2021
Fixes ljharb#403.

Co-authored-by: liaokunhua <acutedev@163.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb added a commit to liaokunhua/qs that referenced this issue Dec 6, 2021
Fixes ljharb#403.

Co-authored-by: liaokunhua <acutedev@163.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb closed this as completed in 9aee773 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants