Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] proper comma parsing of URL-encoded comma #361

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

ljharb
Copy link
Owner

@ljharb ljharb commented Mar 25, 2020

Followup PR to #336. Fixes #311. Fixes #345.

@ljharb
Copy link
Owner Author

ljharb commented Mar 25, 2020

cc @quentinus95; how does this look?

Copy link
Contributor

@quentinus95 quentinus95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be fixing it! Thanks a lot.

@ljharb ljharb changed the title [Tests] failing test for proper comma parsing of URL-encoded commas [Fix] proper comma parsing of URL-encoded comma Mar 25, 2020
@ljharb ljharb merged commit bf0ea91 into master Mar 25, 2020
@ljharb ljharb deleted the fix_comma_parsing branch March 25, 2020 07:09
ljharb added a commit that referenced this pull request Mar 25, 2020
ljharb added a commit that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants