Parsing object with array doesn't split a value

[ghost]

Parsing a query string object with parameter that intended to be an array doesn't split value by comma, while query string in a form of string is parsed correctly.

This is an issue when integrating with frameworks like HAPI that provides query string as a dictionary.

Example

const qs = require('qs');

// Works
console.log(qs.parse('color=a,b', { comma: true }));
// Result: { color: [ 'a', 'b' ] }

// Doesn't work
console.log(qs.parse({ color: 'a,b' }, { comma: true }))
// Result: { color: 'a,b' }
// Expected result as above: { color: [ 'a', 'b' ] }

[ljharb]

parse is meant to take a string, not an object - when it does take an object, it assumes the parsing (including spitting on commas) to already be done.

[ghost]

I see. Then the query parsing example on Hapi is incorrect:
https://hapi.dev/api/?v=19.1.1#-serveroptionsqueryparser

[ljharb]

I don't think it is - i think it's that the "comma" option didn't exist when those docs were written.

[ljharb]

After some of the discussion in the hapi issue, I think that it's reasonable that parse with the object form still can split the commas.

[ghost]

I have prepared a pull request for this: #359