[fix] parsing comma delimited str with percent encoded comma #336
Conversation
… treated as normal text Co-authored-by: Mohamed Omar <mohamed.ahmed.c209@gmail.com> Co-authored-by: Quentin de Longraye <quentin@dldl.fr>
lib/parse.js
Outdated
| } | ||
|
|
||
| if (val && options.interpretNumericEntities && charset === 'iso-8859-1') { | ||
| val = interpretNumericEntities(val); | ||
| } | ||
|
|
||
| if (val && typeof val === 'string' && options.comma && val.indexOf(',') > -1) { | ||
| val = val.split(','); |
There was a problem hiding this comment.
Removing this is a breaking change; it forces anyone using a custom decoder to add this logic where they previously didn't require it.
There was a problem hiding this comment.
i agree, i will look into it more to see what can be done
|
You can pull a non-breaking version here: https://github.com/quentinus95/qs/tree/comma-perecent-parsing |
ljharb
force-pushed
the
comma-perecent-parsing
branch
from
c45429d
to
8aa59b6
Compare
|
@quentinus95 pulled in and rebased, but now the added test is failing. |
ljharb
added
semver-patch: bugfix/patch/etc
and removed
semver-major: breaking change
labels
|
@quentinus95 that was added in #359, and is a pretty important bugfix - so this PR may have to be adapted to work with it. |
|
@ljharb thanks, I've just had a look over it, and it would take too long for me to support the fix (especially because #359 has duplicated some of the logic). I've started to do some refactoring but won't have time to achieve it. If you have some hints on how to fix this without rewriting 20% of the parser, I'll be happy to write the implementation. |
|
Looks like just the test needs to be updated. |
ljharb
force-pushed
the
comma-perecent-parsing
branch
from
8aa59b6
to
cd9a3cd
Compare
| @@ -429,6 +429,14 @@ test('parse()', function (t) { | |||
| st.end(); | |||
| }); | |||
|
|
|||
| t.test('parses comma delimited array while having percent-encoded comma treated as normal text', function (st) { | |||
| st.deepEqual(qs.parse('foo=a%2Cb', { comma: true }), { foo: ['a', 'b'] }); | |||
… treated as normal text (#336) Co-authored-by: Mohamed Omar <mohamed.ahmed.c209@gmail.com> Co-authored-by: Quentin de Longraye <quentin@dldl.fr>
… treated as normal text (#336) Co-authored-by: Mohamed Omar <mohamed.ahmed.c209@gmail.com> Co-authored-by: Quentin de Longraye <quentin@dldl.fr>
changes on the default decoder to correctly parse comma delimited strings while having percent encoded comma
Fixes #311.