[fix] parsing a field that holds array of arrays #335
Conversation
lib/parse.js
Outdated
| @@ -87,6 +87,10 @@ var parseValues = function parseQueryStringValues(str, options) { | |||
| val = val.split(','); | |||
| } | |||
|
|
|||
| if(part.indexOf('[]=') > -1){ | |||
There was a problem hiding this comment.
| if(part.indexOf('[]=') > -1){ | |
| if (part.indexOf('[]=') > -1) { |
what happens with foo[][]=bar, or just []=a?
There was a problem hiding this comment.
foo[][]=bar will be parsed to { foo: ['bar'] }
[]=a will be parsed to { 0: 'a' }
my code doesn't affect these results, it will be the same result
lib/utils.js
Outdated
| @@ -1,7 +1,10 @@ | |||
| 'use strict'; | |||
|
|
|||
| var has = Object.prototype.hasOwnProperty; | |||
| var isArray = Array.isArray; | |||
There was a problem hiding this comment.
whoops, turns out we already depended on this being available ¯\_(ツ)_/¯
There was a problem hiding this comment.
@ljharb yes it is being used in stringify.js file too =D
There was a problem hiding this comment.
@ljharb
should i revert my changes on utils file and make another pr to replace Array.isArray with the polyfill across all the files ?
There was a problem hiding this comment.
nah for now just use Array.isArray the same way it's used in stringify.js.
There was a problem hiding this comment.
okay, will revert my is changes for using this pollyfill
ljharb
force-pushed
the
fix-comma-bracket
branch
from
3da589c
to
f884e2d
Compare
fixes #327