[fix] comma option enabled value parsing to use strings only #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Oct 4, 2019
ljharb
reviewed
Oct 4, 2019
ljharb
pushed a commit
to Om4ar/qs
that referenced
this pull request
Oct 4, 2019
ljharb
force-pushed
the
comma-parse-indexof
branch
from
68c9541
to
982681a
Compare
|
The test you added passes without your fix - can you tweak the test so it fails without the fix? |
ljharb
force-pushed
the
comma-parse-indexof
branch
from
fc51485
to
698b683
Compare
|
@ljharb thank you |
ljharb
pushed a commit
that referenced
this pull request
Mar 24, 2020
ljharb
pushed a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of comma enabled .. parsing should check for strings only when using indexOf(',')
fixes: #328