Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide type argument to encoder/decoder function used by parse/stringify #333

Merged
merged 1 commit into from Sep 13, 2019
Merged

Provide type argument to encoder/decoder function used by parse/stringify #333

merged 1 commit into from Sep 13, 2019

Conversation

Neaox
Copy link
Contributor

@Neaox Neaox commented Sep 12, 2019

Fixes: #290

Duplicates: #332

A new fourth argument is now provided when invoking the decoder inside parse,
this argument represents whether the first argument (str) is a key or a value.
This can then be used to decode key and values different within the decode function.

A test has been added for this new behavior.
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM - could you add some documentation in the readme as well?

@Neaox
Copy link
Contributor Author

Neaox commented Sep 12, 2019

Updated the README as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add options of ignoring uppercase and lowercase
2 participants