fix: follow allowPrototypes during merge

[dead-horse]

closes #200

[dead-horse]

I'm not sure what's the purpose of this commit 50ea161 , but I think it didn't fix prototype overwrite.

[ljharb]

The purpose of the commit is in the commit message, and the added tests shows exactly what it inarguably did fix.

[ljharb]

Change looks good, just a few comments.

[ljharb]

in this case, shouldn't a[b] be entirely overwritten by the string "toString"?

[dead-horse]

I found this test case t.deepEqual(qs.parse('a[b]=c&a=d'), { a: { b: 'c', d: true } }, 'can add keys to objects');, is this a feature by design?

[ljharb]

good point :-) let's keep this as-is for now.

[ljharb]

this file shouldn't be updated in PRs; please revert it.

[dead-horse]

fixed

[dead-horse]

after 50ea161 ,

qs.parse('[=a'); // { a: true }
qs.parse(']=a'); // { ']': 'a'}

Is this the expected result?

[dead-horse]

if we revert the change of var parent = /^([^[\]]*)/; to var parent = /^([^\[\]]*)/;, the only failing test case is:

not ok 135 should be equivalent
  ---
    operator: deepEqual
    expected: |-
      { ']': 'toString' }
    actual: |-
      {}
    at: Test.<anonymous> (/Users/deadhorse/git/github.com/ljharb/qs/test/parse.js:441:12)
  ...

[ljharb]

@dead-horse the second line in your example is the expected result, which is what it did, actually, fix. The first line is an oversight, obviously, hence #200.

[ljharb]

That test is valid; I would expect [=toString to become { '[': 'toString' } as well.

[popomore]

I want to know the diff in 50ea161?diff=split#diff-e6c9a6bca996bc454cc244d17bfeda5cL125

- st.deepEqual(qs.parse('a[]=b&a[t]=u&a[hasOwnProperty]=c', { allowPrototypes: false }), { a: { '0': 'b', c: true, t: 'u' } });
+ st.deepEqual(qs.parse('a[]=b&a[t]=u&a[hasOwnProperty]=c', { allowPrototypes: false }), { a: { 0: 'b', t: 'u' } });

Is it a expected change? it seems a break change that change string to number.

[ljharb]

@popomore in JS, all keys are strings (or Symbols), so { 0: true } and { '0': true } are identical and indistinguishable.