[Tests] Turn on eslint for test files #175
Merged
+72
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigorilla
force-pushed
the
eslint-test
branch
from
5fa4d8c to
9917f9e
Compare
ljharb
requested changes
Oct 15, 2016
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "rules": { | |||
There was a problem hiding this comment.
although i like tabs, this repo is 4-spaced, so this file should be as well
There was a problem hiding this comment.
Yep. I updated the files.
ljharb
approved these changes
Oct 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you made the mistake in the lint command. Because of this eslint did not check test folder.