Feature/encoder decoder #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,6 @@ | |||
| language: node_js | |||
| env: | |||
| - CXX=g++-4.8 | |||
There was a problem hiding this comment.
is this just needed for the iconv dev dep?
|
This looks great! (pending comments) bumping the linter complexity requirements are fine for this. |
martinheidegger
force-pushed
the
feature/encoder-decoder
branch
from
9024793
to
60e326d
Compare
|
Re-pushed squashed commits that use |
martinheidegger
force-pushed
the
feature/encoder-decoder
branch
from
60e326d
to
228107b
Compare
| }); | ||
|
|
||
| t.test('throws error with wrong decoder', function (st) { | ||
| try { |
There was a problem hiding this comment.
instead of try/catch, you can use t.throws(function () { … }, new TypeError('Decoder has to be a function.')) here
martinheidegger
force-pushed
the
feature/encoder-decoder
branch
from
228107b
to
f91a1e5
Compare
|
Pushed squashed commits that changed Error → TypeError and used st.throws instead of an try catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
decoderandencoderoption for querystrings. These option are important when dealing with servers that process data in a form other thanutf8. Namely when trying to send a request to Servers that useshift_jisas method this is an important feature.Note: I choose to add an option instead of re-using the
encodeoption to only require semver-minor. Also I bumped the limit for the linting because I couldn't figure out how to push this change more elegantly.