Commit checks from forks are now included #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Harband <ljharb@gmail.com>
…into resolveSHA
…into resolveSHA
|
I'd have preferred to reuse #62; let's now keep both open so they can be kept in sync. |
ljharb
reviewed
Mar 31, 2022
Comment on lines
+51
to
+55
| return response.repository.commit?.statusCheckRollup?.contexts?.nodes; | ||
| } catch (error) { | ||
| console.log(error); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Suggested change
| return response.repository.commit?.statusCheckRollup?.contexts?.nodes; | |
| } catch (error) { | |
| console.log(error); | |
| return null; | |
| } | |
| } catch (error) { | |
| console.log(error); | |
| return null; | |
| } | |
| return response.repository.commit?.statusCheckRollup?.contexts?.nodes; |
Comment on lines
+59
to
+60
| const node = JSON.parse(JSON.stringify(ogNode)); | ||
| // console.log(JSON.stringify(node,undefined,2)); |
There was a problem hiding this comment.
rather than cloning here, maybe we could { ...ogNode, commit: { ...ogNode.commit, ...newCommit } }?
Comment on lines
+8
to
+10
| const command = short ? `git show ${identifier} -s --format="%h"` : `git show ${identifier} -s --format="%H"`; | ||
| const stdout = String(exec(command)); | ||
| return stdout; |
There was a problem hiding this comment.
Suggested change
| const command = short ? `git show ${identifier} -s --format="%h"` : `git show ${identifier} -s --format="%H"`; | |
| const stdout = String(exec(command)); | |
| return stdout; | |
| const command = `git show ${identifier} -s --format="%${short ? 'h' : 'H'}"`; | |
| return String(exec(command)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52