Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thorough tests #16

Open
ljharb opened this issue Oct 13, 2021 · 4 comments
Open

Add thorough tests #16

ljharb opened this issue Oct 13, 2021 · 4 comments
Assignees
@dani8439
Labels
help wanted PRs are welcome!

Comments

@ljharb
Copy link
Owner

ljharb commented Oct 13, 2021

Let's make sure to add unit tests for each module, and fixtures for the Github API when needed.
@ljharb ljharb added the help wanted PRs are welcome! label Oct 13, 2021
@Green-Ranger11 Green-Ranger11 self-assigned this Oct 13, 2021
@Green-Ranger11
Copy link
Collaborator

Green-Ranger11 commented Oct 13, 2021 •
edited

I also feel this is very important and will get to work on this after working on one of the open prs.

@Green-Ranger11 Green-Ranger11 mentioned this issue Dec 9, 2021
Merged
@dani8439
Copy link
Contributor

I realized I didn't comment on this issue although I spoke with you about it, Jordan. Okay if I try my hand at it?

@ljharb
Copy link
Owner Author

ljharb commented Feb 16, 2022

Absolutely!

@ljharb ljharb assigned dani8439 and unassigned Green-Ranger11 Feb 16, 2022
@ljharb
Copy link
Owner Author

ljharb commented Feb 25, 2022

#34, #59. Not sure what's remaining to be covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dani8439 dani8439

Labels
help wanted PRs are welcome!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @dani8439 @Green-Ranger11