Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #177

Open
FelixJacobi opened this issue Feb 25, 2024 · 3 comments
Open

Improve code quality #177

FelixJacobi opened this issue Feb 25, 2024 · 3 comments
Milestone

Comments

@FelixJacobi
Copy link
Member

  • Strict types, where missing (could break compatibility)
  • Return type hints, where still missing (must be done in a major release, since it breaks compatibility unlike parameter type hints)
@FelixJacobi FelixJacobi added this to the 6.0 milestone Feb 25, 2024
@FelixJacobi
Copy link
Member Author

Rector?

@SamuelWei
Copy link

Can psalm also do this, as we already have it installed

@FelixJacobi
Copy link
Member Author

Yes, it can partly, but it's mainly focused on missing types in code. Rector is more focused on modernizing code in general. Using IServ-GmbH/cotor: The Composer Tools Installer we can just install it and play it around with it ^^ . I will work on this in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants