Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Pydantic V2 Support #218

Closed
JacobCoffee opened this issue May 23, 2023 · 0 comments · Fixed by #222
Closed

Enhancement: Pydantic V2 Support #218

JacobCoffee opened this issue May 23, 2023 · 0 comments · Fixed by #222
Assignees
@Goldziher
Labels
enhancement New feature or request upstream

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented May 23, 2023 •
edited

Summary

The main repo, specifically the work in litestar-org/litestar#1708, relies on Polyfactory in the test suite. I believe this issue is a pre-req to have litestar-org/litestar#1708 completed.

Drawbacks and Impact

Unsure of impact as it stands with the library at large. @gsakkis or @Goldziher maybe you all may have more insight here?

Unresolved questions

Other

Migration Guide
Blog Post

may also be helpful for reference:
@JacobCoffee JacobCoffee added enhancement New feature or request upstream labels May 23, 2023
@JacobCoffee JacobCoffee changed the title Pydantic v2 RFC: Pydantic v2 May 23, 2023
@Goldziher Goldziher self-assigned this May 27, 2023
@Goldziher Goldziher linked a pull request May 27, 2023 that will close this issue
Add pydantic V2 Support #222
Merged
@Goldziher Goldziher changed the title RFC: Pydantic v2 Enhancement: Pydantic V2 Support May 29, 2023
@JacobCoffee JacobCoffee mentioned this issue Jun 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Goldziher Goldziher

Labels
enhancement New feature or request upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pydantic V2 Support litestar-org/polyfactory
2 participants
@Goldziher @JacobCoffee