Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only depend on sample dependencies once npm supports installing transient dependencies from "file:" #6

Open
AndrewJakubowicz opened this issue Apr 15, 2022 · 0 comments
Open

Only depend on sample dependencies once npm supports installing transient dependencies from "file:" #6

AndrewJakubowicz opened this issue Apr 15, 2022 · 0 comments

Comments

@AndrewJakubowicz
Copy link
Contributor

AndrewJakubowicz commented Apr 15, 2022 •
edited

See issue npm/cli#2339 and PR npm/cli#4745.

NPM currently won't install transient dependencies from a file: dep.

Once this issue is resolved we can remove the explicit dependency on lit, which will be installed from "simple-carousel".
@AndrewJakubowicz AndrewJakubowicz changed the title Depend on sample dependencies once npm supports installing transient dependencies from "file:" Only depend on sample dependencies once npm supports installing transient dependencies from "file:" Apr 15, 2022
AndrewJakubowicz added a commit that referenced this issue Apr 15, 2022
@AndrewJakubowicz
Add explicit dep on lit as workaround for npm file: dep issue
ea7abbf 
#6
@AndrewJakubowicz AndrewJakubowicz mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewJakubowicz