You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently added node build would crash when importing a component that had both static styles and used the @property decorator. That's because the @property decorator causes Lit class initialization at module load time, which ran an instanceof CSSStyleSheet check before this PR. Since CSSStyleSheet is not defined by default, the error would occur.
This PR fixes that by not assuming CSSStyleSheet will be defined when in Node mode.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added
node
build would crash when importing a component that had bothstatic styles
and used the@property
decorator. That's because the@property
decorator causes Lit class initialization at module load time, which ran aninstanceof CSSStyleSheet
check before this PR. SinceCSSStyleSheet
is not defined by default, the error would occur.This PR fixes that by not assuming
CSSStyleSheet
will be defined when in Node mode.Fixes #3218