Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-html] Provide directive exports via async-directive #3003

Merged
merged 7 commits into from Jul 25, 2022

Conversation

sorvell
Copy link
Member

@sorvell sorvell commented Jun 7, 2022

Fixes #2790. This is being done for convenience.

Steven Orvell added 2 commits June 6, 2022 17:51
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: 3aa478b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
lit-html Patch
lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-0.51ms - +0.61ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 86.89ms - 89.49ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +4% (-0.39ms - +1.23ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +1% (-0.31ms - +0.12ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-1.43ms - +0.47ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +2% (-0.87ms - +1.56ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 890.48ms - 903.29ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-1.51ms - +3.24ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-5.64ms - +3.95ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.70ms - +1.00ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-13.59ms - +3.58ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 896.82ms - 908.15ms
  • reactive-element-list: unsure 🔍 -0% - +4% (-1.14ms - +38.42ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
86.89ms - 89.49ms-

update

VersionAvg timevs
890.48ms - 903.29ms-

update-reflect

VersionAvg timevs
896.82ms - 908.15ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
34.08ms - 35.05ms-unsure 🔍
-1% - +4%
-0.39ms - +1.23ms
unsure 🔍
-1% - +3%
-0.22ms - +0.89ms
tip-of-tree
tip-of-tree
33.50ms - 34.80msunsure 🔍
-4% - +1%
-1.23ms - +0.39ms
-unsure 🔍
-2% - +2%
-0.79ms - +0.63ms
previous-release
previous-release
33.95ms - 34.51msunsure 🔍
-3% - +1%
-0.89ms - +0.22ms
unsure 🔍
-2% - +2%
-0.63ms - +0.79ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
93.50ms - 96.63ms-unsure 🔍
-2% - +3%
-1.51ms - +3.24ms
unsure 🔍
-4% - +3%
-3.71ms - +3.00ms
tip-of-tree
tip-of-tree
92.42ms - 95.99msunsure 🔍
-3% - +2%
-3.24ms - +1.51ms
-unsure 🔍
-5% - +2%
-4.68ms - +2.24ms
previous-release
previous-release
92.45ms - 98.39msunsure 🔍
-3% - +4%
-3.00ms - +3.71ms
unsure 🔍
-2% - +5%
-2.24ms - +4.68ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.60ms - 30.42ms-unsure 🔍
-2% - +2%
-0.51ms - +0.61ms
unsure 🔍
-3% - +1%
-1.01ms - +0.33ms
tip-of-tree
tip-of-tree
29.58ms - 30.35msunsure 🔍
-2% - +2%
-0.61ms - +0.51ms
-unsure 🔍
-3% - +1%
-1.04ms - +0.27ms
previous-release
previous-release
29.82ms - 30.88msunsure 🔍
-1% - +3%
-0.33ms - +1.01ms
unsure 🔍
-1% - +3%
-0.27ms - +1.04ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.01ms - 12.30ms-unsure 🔍
-3% - +1%
-0.31ms - +0.12ms
unsure 🔍
-3% - +1%
-0.36ms - +0.08ms
tip-of-tree
tip-of-tree
12.09ms - 12.41msunsure 🔍
-1% - +3%
-0.12ms - +0.31ms
-unsure 🔍
-2% - +1%
-0.27ms - +0.18ms
previous-release
previous-release
12.13ms - 12.46msunsure 🔍
-1% - +3%
-0.08ms - +0.36ms
unsure 🔍
-1% - +2%
-0.18ms - +0.27ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
341.05ms - 347.34ms-unsure 🔍
-2% - +1%
-5.64ms - +3.95ms
unsure 🔍
-2% - +1%
-5.62ms - +2.87ms
tip-of-tree
tip-of-tree
341.42ms - 348.66msunsure 🔍
-1% - +2%
-3.95ms - +5.64ms
-unsure 🔍
-1% - +1%
-5.13ms - +4.07ms
previous-release
previous-release
342.73ms - 348.42msunsure 🔍
-1% - +2%
-2.87ms - +5.62ms
unsure 🔍
-1% - +1%
-4.07ms - +5.13ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
61.29ms - 62.35ms-unsure 🔍
-2% - +1%
-1.43ms - +0.47ms
unsure 🔍
-1% - +1%
-0.81ms - +0.82ms
tip-of-tree
tip-of-tree
61.52ms - 63.09msunsure 🔍
-1% - +2%
-0.47ms - +1.43ms
-unsure 🔍
-1% - +2%
-0.51ms - +1.49ms
previous-release
previous-release
61.20ms - 62.43msunsure 🔍
-1% - +1%
-0.82ms - +0.81ms
unsure 🔍
-2% - +1%
-1.49ms - +0.51ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
132.65ms - 135.42ms-unsure 🔍
-2% - +1%
-2.70ms - +1.00ms
unsure 🔍
-1% - +2%
-1.10ms - +2.84ms
tip-of-tree
tip-of-tree
133.66ms - 136.12msunsure 🔍
-1% - +2%
-1.00ms - +2.70ms
-unsure 🔍
-0% - +3%
-0.14ms - +3.58ms
previous-release
previous-release
131.77ms - 134.57msunsure 🔍
-2% - +1%
-2.84ms - +1.10ms
unsure 🔍
-3% - +0%
-3.58ms - +0.14ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
63.64ms - 65.37ms-unsure 🔍
-1% - +2%
-0.87ms - +1.56ms
unsure 🔍
-1% - +2%
-0.94ms - +1.55ms
tip-of-tree
tip-of-tree
63.30ms - 65.02msunsure 🔍
-2% - +1%
-1.56ms - +0.87ms
-unsure 🔍
-2% - +2%
-1.28ms - +1.20ms
previous-release
previous-release
63.30ms - 65.10msunsure 🔍
-2% - +1%
-1.55ms - +0.94ms
unsure 🔍
-2% - +2%
-1.20ms - +1.28ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
907.36ms - 918.65ms-unsure 🔍
-1% - +0%
-13.59ms - +3.58ms
unsure 🔍
-1% - +1%
-6.01ms - +8.68ms
tip-of-tree
tip-of-tree
911.54ms - 924.47msunsure 🔍
-0% - +1%
-3.58ms - +13.59ms
-unsure 🔍
-0% - +2%
-1.66ms - +14.34ms
previous-release
previous-release
906.96ms - 916.37msunsure 🔍
-1% - +1%
-8.68ms - +6.01ms
unsure 🔍
-2% - +0%
-14.34ms - +1.66ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1014.01ms - 1042.90ms-unsure 🔍
-0% - +4%
-1.14ms - +38.42ms
unsure 🔍
-1% - +3%
-5.64ms - +33.50ms
tip-of-tree
tip-of-tree
996.30ms - 1023.33msunsure 🔍
-4% - +0%
-38.42ms - +1.14ms
-unsure 🔍
-2% - +1%
-23.60ms - +14.18ms
previous-release
previous-release
1001.33ms - 1027.73msunsure 🔍
-3% - +1%
-33.50ms - +5.64ms
unsure 🔍
-1% - +2%
-14.18ms - +23.60ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Co-authored-by: Augustine Kim <augustinekim@google.com>
@sorvell sorvell merged commit daddeb3 into main Jul 25, 2022
@sorvell sorvell deleted the directive-export branch July 25, 2022 18:35
@lit-robot lit-robot mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lit-html] Consider re-exporting out of async-directive
4 participants